Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Duplicate Zero Address Validation Check

The transferErcTokens function in the TokenDivider contract contains a redundant validation check for the zero address, performing the same verification twice without any additional security benefit.

Lines of Code

function transferErcTokens(address nftAddress, address to, uint256 amount) external {
// First check
if(to == address(0)) {
revert TokenDivider\_\_CantTransferToAddressZero();
}
// ... other validations ...
// Second duplicate check
if(to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
}

Fix Recommendation

Remove the second zero address check

This saves gas and improves contract quality

Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.