Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Duplicate onlyNftOwner in divideNft function

Summary

Duplicate onlyNftOwner modifier is going to spend gass without any benefit.

Vulnerability Details

The onlyNftOwner modifier is checking if the msg.sender is the owner of the given nftAddress & tokenId.

While it's correct to have it on the function, there is no benefit to having it twice.

Impact

The modifiers will be executed twice without, doing the same check. That would spend gass

Tools Used

Manual review

Recommendations

Keep only one modifier on the function.

Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.