Submission Details
Severity:
The event OrderSelled is in wrong place in buyOrder function
Summary
The buyOrder function in the smart contract facilitates the purchase of a sell order.
Vulnerability Details
The event OrderSelledis before order transfer logic.
Impact
Events are crucial for logging important actions and changes. Placing them incorrectly can result in missing or misleading logs, making it difficult to trace contract behavior and identify issues
Tools Used
manual review
Recommendations
Please move OrderSelled at the end of buyOrderfunction.
IERC20(order.erc20Address).transfer(msg.sender, order.amount);
emit OrderSelled(msg.sender, order.price);
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.