Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: high
Valid

Sell orders cannot be cancelled causing ERC20 to be stucked or bought back

Summary

Users can create sell ERC20 orders but there is no way to cancel an order without paying unexpected taxes.

Vulnerability Details

  • A user can create sell orders in TokenDivider::sellErc20

  • No one buys or a user wants to get back his ERC20 shared

  • The user cannot cancel his order or modify his order and would have to buy his own order in ETH, thus paying the fee from TokenDivider::buyOrder

Impact

  • Unexpected loss of fund, and friction

Recommendations

  • Add a function for cancelling a sell order

  • Authorize the seller to buy his own order with no tax

Updates

Lead Judging Commences

juan_pedro_ventu Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Sell orders cant be canceled

Appeal created

kweks Auditor
4 months ago
0xalexsr Submitter
4 months ago
riceee Auditor
4 months ago
0xalexsr Submitter
4 months ago
juan_pedro_ventu Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Sell orders cant be canceled

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.