Submission Details
Severity:
Incorrect Fee Calculation
Summary:The buyOrder function calculates fees using integer division, which can result in a fee of 0 for small order prices
Vulnerability Details
uint256 fee = order.price / 100;
uint256 sellerFee = fee / 2;
Impact:errors could result in incorrect fees being deducted.
Tools Used:Manual code review
Recommendations:Implement percentage-based calculations with proper rounding
uint256 fee = (order.price * 100) / 10000; // 1% fee
uint256 sellerFee = fee / 2;
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.