Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Use of duplicate modifier

Summary

There is use of same modifier twice in "divideNft" function of "TokenDivider.sol" which usage unnecessary gas.

Vulnerability Details

"onlyNftOwner" modifier is used twice in "divideNft" function of "TokenDivider.sol", which cost unnecessary gas.

function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress ,tokenId) onlyNftOwner(nftAddress ,tokenId) external { ........}

It cost 715771 gas with twice use of modifier .
It cost 714241 gas with single use of modifier.

Impact

Use of unnecessary gas.

Tools Used

Manual review.

Recommendations

Use only "onlyNftOwner" for once.

Updates

Lead Judging Commences

fishy Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.