Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Redundant modifier check

Vulnerability Details

The divideNft function uses the onlyNftOwner modifier twice, which is redundant and doesn't add any extra security.

function divideNft(address nftAddress, uint256 tokenId, uint256 amount)
external
@> onlyNftOwner(nftAddress, tokenId)
@> onlyNftOwner(nftAddress, tokenId) //@audit-issue duplicate onlyNftOwner
{

Impact

Higher gas costs for users calling the function.

Tools Used

Manual Review

Recommendations

One instance should be removed.

Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.