Submission Details
Severity:
Incorrect Ether Amount Validation in buyOrder Function
Summary
In the buyOrder function, the Ether amount validation checks if the buyer sends order.price + sellerFee as part of the payment. However, the buyer should only send order.price, as the seller fee is deducted internally from the price and the fee is deducted from it before transferring the Ether to the seller. This incorrect validation will cause the transaction to revert unnecessarily.
Vulnerability Details
if (msg.value < order.price + sellerFee) {
revert TokenDivider__InsuficientEtherForFees();
}
Wrong check for order price.
Impact
Buyers attempting to purchase tokens will have their transactions reverted even if they send the correct order.price amount.
Tools Used
Manual Review
Recommendations
if (msg.value < order.price) {
revert TokenDivider__IncorrectEtherAmount();
}
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.