Summary

In TokenDivider, there are token transfer function in transferErcTokens(),sellErc20()and buyOrder(), it does not check the return value.

Vulnerability Details

IERC20.transferFrom()has return value to check if the transfer is failed. However, it does not apply in transferErcTokens(), sellErc20()and buyOrder(). Some tokens (e.g., USDT) return false instead of reverting on failure. Contract logic might continue as if the transfer succeeded, leading to unintended behavior.

Impact

Potential unauthorized token transfers

Tools Used

Manual Review

Recommendations

Use SafeERC20 from Openzepplin , or ensure that the transfer/transferFrom return value is checked.