Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

[L-5] `public` functions not used internally could be marked `external`

Instead of marking a function as public, consider marking it as external if it is not used internally.

5 Found Instances

  • Found in src/TokenDivider.sol Line: 316

    function getBalanceOf(address user, address token) public view returns(uint256) {
  • Found in src/TokenDivider.sol Line: 320

    function getErc20TotalMintedAmount(address erc20) public view returns(uint256) {
  • Found in src/TokenDivider.sol Line: 324

    function getErc20InfoFromNft(address nft) public view returns(ERC20Info memory) {
  • Found in src/TokenDivider.sol Line: 328

    function getOrderPrice(address seller, uint256 index) public view returns(uint256 price) {
  • Found in src/token/ERC20ToGenerateNftFraccion.sol Line: 15

    function mint(address _to, uint256 _amount) public {
Updates

Lead Judging Commences

fishy Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.