Pieces Protocol

Summary

The divideNft function generates and mints an ERC20 token as a fraction of an NFT and then transfers the NFT from msg.sender to the contract. However, the current implementation:

1. Updates (balances, erc20ToMintedAmount, erc20ToNft) **after **calling TranssafeferFrom.

2. TranssafeferFrom uses the = assignment operator instead of += for balances and erc20ToMintedAmount.

Vulnerability Details

State Updates after TranssafeferFrom is called.

Incorrect Assignment (= instead of +=):

Using = instead of += inbalances, erc20ToMintedAmount, and erc20ToNft

This causes balances and total minted amounts to reset if the function is called multiple times for the same token.

Impact

Inconsistent State: If the transfer fails, the contract state will not match expectations.

• Loss of Data: Reassigning instead of incrementing (+=) can overwrite existing values, causing loss of balances or previously minted amounts.

• Exploitation: A malicious actor might exploit the overwritten values, particularly if they can reset or manipulate state variables intentionally.

Tools Used

Manual review

Recommendations

Updating state before calling TranssafeferFrom, and replace = with +=.