Submission Details
Severity:
Multiple checks for owner of the nft in `TokenDivider::divideNft` function.
Description
`TokenDivider::divideNft` function checks for owner of thr nft before perform anything, As the modifier refers only owner of the nft can call the `divideNft` function.
But the function is checking for owner twice shown in code below.
```javascript
@> function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress, tokenId) onlyNftOwner(nftAddress ,tokenId) external {
```
Impact
The `divideNft` function will check twise for owner of the nft.
Recommendations
The `onlyNftOwner` modifier should only be called or required once in the function call.
```diff
- function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress, tokenId) onlyNftOwner(nftAddress ,tokenId) external {
+ function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress, tokenId) onlyNftOwner(nftAddress ,tokenId) external {
```
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.