distributeProtocolAssetReward
function in the MarketMakingEngineConfiguration.sol contract has a potential rounding issue in the calculation of the fee recipient reward. The current implementation may result in rounding errors, leading to discrepancies in the distributed rewards.The calculation of feeRecipientReward
may result in rounding errors, which can lead to discrepancies in the distributed rewards. The current implementation does not explicitly handle rounding, which may cause issues when the total distributed amount does not match the expected amount.
Impact
The impact of this issue is that it can lead to discrepancies in the distributed rewards, potentially causing some fee recipients to receive slightly more or less than their intended share. This can lead to fairness issues and potential disputes among fee recipients.
manual
To mitigate this issue, it is recommended to explicitly handle rounding in the calculation of feeRecipientReward. This can be achieved by nding function to ensure that the calculated reward is rounded down.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.