Submission Details
Severity:
Corruptible Upgradability Pattern
Summary
Swap.sol is not designed for upgrade. This library is missing __gap array for upgradability.
Vulnerability Details
Zeros has tree proxy pattern for upgradability. But this library has no gap
Impact
Storage of vault contracts might be corrupted during upgrading.
Tools Used
Recommendations
Modify the structure of contracts
struct Data {
address assetFrom; // 20 bytes
uint96 amount; // 12 bytes (fits in the same slot as address)
uint128 minUsdTokenOut; // 16 bytes
uint128 deadline; // 16 bytes
uint256[50] __gap; // Reserved storage gap for future upgrades
}
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.