Submission Details
Severity:
Owner cannot increment the recipients shares.
Summary
When the owner tries to increment the recipient shares then he will get the revert due to having a state:
totalFeeRecipientsSharesX18 + share > MAX_CONFIGURABLE_PROTOCOL_FEE_SHARES ==> revert
Vulnerability Details
Lets say owner set the fee recipient = 0.5e18 share.
So in order to increment above recipient's share owner needs to enter greater amount than previous.
However he will not able to do that because recipient previous + new share will greater than max shares.
i.e => Owner want to set that fee recipient share = 0.6e18 shares.
0.5e18 + 0.6e18 > 0.9e18 ===> revert.
Impact
The owner cannot re-configure the same recipient and increment his shares.
Tools Used
Manual review.
Recommendations
Implement new logic.
Updates
Lead Judging Commences
inallhonesty 10 months ago
Submission Judgement Published Assigned finding tags:
MarketMakingEngineConfigurationBranch::configureFeeRecipient can cause DOS when attempting to change share value of an existing address
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821
USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.