Submission Details
Severity:
The `FeeDistributionBranch::convertAccumulatedFeesToWeth` function incorrectly distributes the reward with `tokenIn`.
Summary
The FeeDistributionBranch::convertAccumulatedFeesToWeth function incorrectly distributes the reward with tokenIn.
Vulnerability Details
The convertAccumulatedFeesToWeth function converts the any asset into the weth and then distributes the rewards for protocol and markets . However, this function mistakenly sends the weth amount with tokenIn instead of tokenOut.
Impact
The protocol and market will receive the reward in wrong token.
Tools Used
Manual review.
Recommendations
- _handleWethRewardDistribution(market, asset, ctx.receivedWethX18);
+ _handleWethRewardDistribution(market, ctx.weth, ctx.receivedWethX18);
Updates
Lead Judging Commences
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
FeeDistributionBranch::convertAccumulatedFeesToWeth passes input token instead of WETH to _handleWethRewardDistribution, causing incorrect reward tracking
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.