Summary

Function convertAccumulatedFeesToWeth approve the collateral token.

Vulnerability Details

ERC20 functions may not behave as expected. For example: return values are not always meaningful.

ERC-20 functions like approve(), transfer(), and transferFrom() do not always behave as expected.

• Some tokens do not return a boolean (true/false) when calling these functions.

• Others return false instead of reverting on failure, meaning the transaction does not revert but still fails silently.

Impact

If a token fails to approve, the contract will not know, and the transaction will continue as if the approval was successful, leading to unexpected behavior or security risks.

Tools Used

Manual review

Recommendations

It is recommended to use OpenZeppelin's SafeERC20 library, and replace approve with safeApprove