Submission Details
Severity:
Unbounded Loops in Credit Calculations
Summary
getCreditForMarketId uses loops without gas limit considerations, risking DOS.
Vulnerability Details
// In CreditDelegationBranch.sol
function getCreditForMarketId(uint256 marketId) public view returns (uint256) {
uint256 totalCredit;
for (uint256 i = 0; i < allVaults.length; i++) {
if (vaultSupportsMarket(allVaults[i], marketId)) {
totalCredit += vaults[allVaults[i]].liquidity;
}
}
return totalCredit;
}
Impact
Gas limits exceeded for markets with many vaults
Failed transactions during market stress
Tools Used
Manual review
Ethlint
Recommendations
// Implement paginated view functions
function getCreditPaginated(uint256 marketId, uint256 start, uint256 end) public view returns (uint256) {
uint256 totalCredit;
end = Math.min(end, allVaults.length);
for (uint256 i = start; i < end; i++) {
if (vaultSupportsMarket(allVaults[i], marketId)) {
totalCredit += vaults[allVaults[i]].liquidity;
}
}
return totalCredit;
}
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.