Submission Details
Severity:
`rebalanceVaultsAssets` will always revert
Summary
Wrong logic in the rebalanceVaultsAssets will cause the function to always revert.
Vulnerability Details
In the rebalanceVaultsAssets we can see that the function will assume that a vault is in debt when its unsettledRealizedDebt is negative. However this is actually wrong as a vault is in debt when the unsettled debt is positive. This will cause the following checks to always revert:
// cache the in debt vault & in credit vault unsettled debt
SD59x18 inDebtVaultUnsettledRealizedDebtUsdX18 = inDebtVault.getUnsettledRealizedDebt();
SD59x18 inCreditVaultUnsettledRealizedDebtUsdX18 = inCreditVault.getUnsettledRealizedDebt();
// revert if 1) the vault that is supposed to be in credit is not OR
// 2) the vault that is supposed to be in debt is not
if (
inCreditVaultUnsettledRealizedDebtUsdX18.lte(SD59x18_ZERO)//@audit vault is indeed in credit if it is less than 0
|| inDebtVaultUnsettledRealizedDebtUsdX18.gte(SD59x18_ZERO)
) {
revert Errors.InvalidVaultDebtSettlementRequest();
}
Impact
rebalanceVaultsAssets can never be used
Tools Used
Manual Review
Recommendations
A vault is in debt when getUnsettledRealizedDebt returns a positive value.
Updates
Appeal created
novaman33
10 months ago
inallhonesty
10 months ago
inallhonesty 9 months ago
Submission Judgement Published Assigned finding tags:
Improper if conditions inside `rebalanceVaultsAssets` cause reverts when it shouldn't
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821
USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.