The configureFeeRecipient()
function allows the protocol to allocate a high fee to itself, breaking economic invariants and disincentivising user participation. The MAX_CONFIGURABLE_PROTOCOL_FEE_SHARES
allows the protocol to claim up to the maximum defined value, This can risk system instability.
The constant MAX_CONFIGURABLE_PROTOCOL_FEE_SHARES
is set to 0.9e18
90
percent this allows the protocol to claim nearly all the fees.
Using gte()
will be more preferable to using .gt()
as this allows the protocol to alocate exactly 90 percent of fees as 0.9e18.gt(0.9e18)
returns false.
Allocating 90 percent of fees will leave very minimal reward for LPs and Users discouraging participation.
Centralizing fees will break trust as every user expects a fair fee distribution.
Manual review
Lowering the MAX_CONFIGURABLE_PROTOCOL_FEE_SHARES
to 0.8e18(80%) will bemore preferable.
Use `.gte()) to prevent reaching exact cap.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.