Submission Details
Severity:
Inconsistency with Uniswap V3
Summary
The UniswapV3Adapter.sol setPoolFee function accepts 3 Uniswap V3 fee tiers (1%, 0.3%, 0.05%, and 0.01%).
Impact
The issue is that uniswap supports more feeTiers:
:
Users will not be able to set the pool fee to 0.01% (100 bps), which is a valid fee tier supported by Uniswap V3. The 0.01% fee tier is designed for very stable pairs with low volatility. Excluding this fee tier may result in missed opportunities for optimizing trading fees for such pairs.
Recommendations
The
setPoolFeefunction should be updated to include all valid fee tiers:
function setPoolFee(uint24 newFee) public onlyOwner {
// revert if the new fee is not 100, 500, 3000 or 10_000
- if (newFee != 500 && newFee != 3000 && newFee != 10_000) revert Errors.InvalidPoolFee();
+ if (newFee != 100 && newFee != 500 && newFee != 3000 && newFee != 10_000) revert Errors.InvalidPoolFee();
. . .
}
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.