Summary

Redundant Fee Check in VaultRouterBranch::deposit

Vulnerability Details

Before transfering `ctx.assetFees` the code checks that it is greter than zero.

However there is no need for this check as it is already handled earlier in the execution:

Impact

Unnecessary gas usage: The extra conditional check slightly increases gas consumption.

Tools Used

Manual review

Recommendations

Remove the redundant if (ctx.assetFees > 0) check before safeTransferFrom, as ctx.assetFees is always nonzero when the fee is enforced.