Part 2

​

`ctx.vaultAsset` and `ctx.usdc` variables misassignment in the `else` block of `CreditDelegationBranch::settleVaultsDebt`.

​

​

In `CreditDelegationBranch::settleVaultsDebt`, when the vault is in credit(that is, the vault has more USDC than vault

assets) the `else` block is triggered which makes a call to `CreditDelegationBranch::calculateSwapAmount` to get the amount

of USDC needed to be swapped to vault asset.

​

The function `CreditDelegationBranch::calculateSwapAmount` takes the parameters:

​

1. `dexAdapter`: The address of the DEX adapter used for price calculation.

2. `assetIn`: The address of the USDC token to calculate the amount for. The address of the USDC to be swapped for

vaultasset.

3. `assetOut`: The address of the vault asset.

4. `vaultUnsettledDebtUsdAbs`: The unsettled debt in USD in native token precision.

​

However, the function call(`CreditDelegationBranch::calculateSwapAmount`) in the `else` block misarrange these parameters

using `ctx.vaultAsset` as `assetIn` instead of `ctx.vaultAsset` being the `assetOut` and using `ctx.usdc` as `assetOut`

instead of `ctx.usdc` being the `assetIn`.

​

ctx.usdcIn = calculateSwapAmount(

dexSwapStrategy.dexAdapter,

ctx.vaultAsset,

ctx.usdc,

usdcCollateralConfig.convertSd59x18ToTokenAmount(ctx.vaultUnsettledRealizedDebtUsdX18.abs()),

);

​

​

This calculate incorrect amount of USDC(`ctx.usdc`) to be swapped for vault assets(`ctx.vaultAsset`) which in turn swap

incorrect amount of USDC(`ctx.usdc`) for the vault assets(`ctx.vaultAsset`).

​

​

Change the position of `ctx.vaultAsset` for the position of `ctx.usdc`

​

​

- ctx.vaultAsset,

+ ctx.usdc,

- ctx.usdc,

+ ctx.vaultAsset,