Submission Details
Severity:
Lack of arrays check
## Summary
Lack of arrays comparison between `assets` and `dexSwapStrategyIds` in `FeeDistributionBranch::_performMultiDexSwap`
## Vulnerability Details
The function `FeeDistributionBranch::_performMultiDexSwap` lacks if the dex swap strategy Ids present in `dexSwapStrategyIds`
array correspond to the assets present in `assets` array.
## Impact
Unexpected behaviour
## Recommendations
Add a check to enforce that the length of `assets` array is greater than `dexSwapStrategyIds` array by 1.
```diff
+ require(assets.length - 1 == dexSwapStrategyIds.length, "Invalid array lengths");
```
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.