Part 2

​

Missing `address(0)` check for `marketMakingEngineConfiguration.referralModule` in `VaultRouterBranch::deposit`.

​

​

Refferal code for first time depositor is registerred if `bytes memory referralCode` is not empty. During this registration,

an external call is made to `IReferral::registerReferral` to register the code. However, there is no check if

`marketMakingEngineConfiguration.referralModule` has been set by the owner.

​

​

Unexpected behaviour

​

​

Enforce a check for the address of `marketMakingEngineConfiguration.referralModule` before the registration.

​

+ error InvalidReferralModuleAddress();

​

+ if(ctx.referralModule == address(0)) {

+ revert InvalidReferralModuleAddress();

+ }