Part 2
Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

In FeeDistributionBranch.sol::getAssetValue there is missing Asset Price Validation

shrxyeh

Summary

The function getAssetValue retrieves asset prices without validating their freshness or reliability.

Vulnerability Details

  • The function does not check the validity of asset prices.

  • Stale or manipulated prices could affect asset valuations.

function getAssetValue(address asset, uint256 amount) public view returns
(uint256 value) {
Collateral.Data storage collateral = Collateral.load(asset);
UD60x18 priceX18 = collateral.getPrice();
// ... calculations without price validation
}

Impact

Inaccurate asset valuations impacting fee distributions.

Tools Used

Manual code review.

Recommendations

  • Validate the freshness and reliability of asset prices.

  • Implement checks for price validity.

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!