Part 2

​

Possible override of state variable `slippageToleranceBps` by external contract in `BaseAdapter`.

​

​

The initialize function `BaseAdapter::__BaseAdapter_init` initializes the owner through `__Ownable_init(owner)` and set

`slippageToleranceBps` through the function `setSlippageTolerance(_slippageToleranceBps)` with `100` being the minimum

slippage tolerance.

​

However, `CurveAdapter::initialize`, `UniswapV2Adapter::initialize` and `UniswapV3Adapter::initialize` calls

`BaseAdapter::__BaseAdapter_init` to initialize the owner and set the `slippageToleranceBps` which is stored in `BaseAdapter`

​

For example, if `BaseAdapter::__BaseAdapter_init` is called to initialize the `owner` and set the `slippageToleranceBps` as

`100` the state variable `slippageToleranceBps` will be `100`.

​

Then, if `CurveAdapter::initialize` calls `BaseAdapter::__BaseAdapter_init` to initialize the owner and set the

`slippageToleranceBps` with `owner` as `address(1)` and `_slippageToleranceBps` as `500`. The state variable

`slippageToleranceBps` in `BaseAdapter` will be `500` instead of `100`.

​

​

This will affect/alter the expected amount in `BaseAdapter::calculateAmountOutMin` causing a decrease in expected

`amountOutMin`.