Submission Details
Severity:
Opposition of NatSpec
## Summary
Opposition of NatSpec in `UniswapV3Adapter::setPoolFee`
## Vulnerability Details
The NatSpec of the function `UniswapV3Adapter::setPoolFee` says "@dev the minimum is 1000 (e.g. 0.1%)" but the logic of the
function allows the deposit of `500` which is lower than `1000`.
## Impact
The pool charge lesser fee than required.
## Recommendations
Add the check below to the logic of `UniswapV3Adapter::setPoolFee`.
```diff
function setPoolFee(uint24 newFee) public onlyOwner {
// revert if the new fee is not 500, 3000 or 10_000
- if (newFee != 500 && newFee != 3000 && newFee != 10_000) revert Errors.InvalidPoolFee();
+ if(newFee < 1000 || newFee > 10_000) {
+ revert Errors.InvalidPoolFee();
+ }
// set the new fee
feeBps = newFee;
// emit the event
emit LogSetPoolFee(newFee);
}
```
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821
USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.