Submission Details
Severity:
Missing state in DexSwapStrategy :: Data struct
[H-2] Missing state in DexSwapStrategy :: Data struct
Description: According to netspac in DexSwapStrategy :: Data struct, the protocol initially includes baseFeeUsd which is the base fee in usd paid to the protocol fee recipients to cover keeper costs.
This shows baseFeeUsd is a very important state
Impact:
protocol will be missing on fees , which at first was'nt protocol initial plan.
Proof of Concept:
/// @notice DexSwapStrategy data storage struct.
/// @param id The unique identifier of the DexSwapStrategy.
/// @param baseFeeUsd The base fee in usd paid to the protocol fee recipients to cover keeper costs.
/// @param dexAdapter The address of the DexAdapter contract.
// @audit baseFeeUsd was included in the netspac but removed in the struct
struct Data {
uint128 id;
address dexAdapter;
}
Recommended Mitigation:
include the baseFeeUsd back in the Data struct of DexSwapStrategy , and implement any other implementation needed
struct Data {
uint128 id;
uint128 baseFeeUsd
address dexAdapter;
}
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.