Part 2

Summary

Storage reference is passed to a function with a memory parameter. This will not update the storage variable as expected.

Vulnerability Details

we have in the CreditDelegationBranch::_convertAssetsToUsdc function a parameter which is specified as a memory the path parameter,
but in the function call in line Line: 447, the 4th argument is declared as storage while the function expects a memory parameter.
that also happens in line Line: 500, with the function CreditDelegationBranch::_convertUsdcToAssets.

Impact

This means that if the path parameter changes in CreditDelegationBranch::_convertAssetsToUsdc function or the other one, the storage argument that is passed in the function call will not get changed .

Tools Used

Recommendations

In this case the path parameter did not change so there is no risk, but in general using storage instaed of memory would be better.