Submission Details
Severity:
Deadline Can Lead To DoS Or Gain Loss
Summary
The UniswapV2Adapter and UniswapV3Adapter use a deadline. However, the deadline is a storage variable set only by the owner. In the case in which it is set in the further future it will lead to gains loss (due to no way of a user cancelling his request) and in the case in which the owner didn't update it before a swap it will lead to a DoS (due to the deadline being in the past).
Impact
Gains loss and DoS.
Tools Used
Manual Review
Recommendations
Either use block.timestamp as a deadline or let users choose their own deadline.
Prize pool breakdown
Total prize
70,000 USDC
nSLOC
3,25821 USDC / LOC
66,500
3,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.