Part 2

Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of support for ETH

Summary

Documentation states that ETH is in scope however their is no handling of native ETH making it incompatible with this protocol.

Vulnerability Details

Documentation scope includes ETH as one of the tokens in scope.

Compatibilities:
Chain(s) to deploy to::
- Arbitrum
- Monad
Tokens:
- ETH
- WETH
- WEETH
- WSTETH
- WBTC
- USDC
- USDT
- USDE
- SUSDE
- ERC721 (Zaros Account NFT, AccountNFT.sol)

However, native eth is not handled in any of the core functionalities of the protocol. For example, it cannot be used to be deposited as credit because depositCreditForMarket is not payable and has no logic for native ETH.

function depositCreditForMarket(
uint128 marketId,
address collateralAddr,
uint256 amount
)
external
onlyRegisteredEngine(marketId)
{

Impact

ETH is not compatible with protocool

Tools Used

Manual Review

Recommendations

Either state ETH is not to be used or modify logic to handle native currency

Updates

Lead Judging Commences

inallhonesty Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.