MarketMakingEngineConfigurationBranch : the initialize function is not added. The same happen in other branch contract as well.
Summary
The contract is not implemented with initialize function which makes it not possible to set the owner address
Vulnerability Details
MarketMakingEngineConfigurationBranch is up-gradable contract branch contract. There are other branches implemented to work as individual entity and support the zaro market implementation.
when deploying the contract, the initialize of the each contract's function is planned to call. But these branch contract does not implement the initialize functions.
Impact
Branch contracts can not be initialized.
For example, the MarketMakingEngineConfigurationBranch contrct inherits owneable_upgradable. The contract can not set its owner.
Tools Used
Manual review.
Recommendations
Suggestion : add initialize function in each of the branches
Lead Judging Commences
`_Ownable_init()` is not called in `MarketMakingEngineConfigurationBranch` contract
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.