Part 2
Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Deadline is not checked in CurveAdapter

h2134

Summary

Deadline is not checked in CurveAdapter.

Vulnerability Details

CurveAdapter owner can set deadline.

BaseAdapter::setDeadline():

function setDeadline(uint256 _deadline) public onlyOwner {
// revert if the deadline is in the past
if (_deadline < block.timestamp) revert Errors.SwapDeadlineInThePast();
​
// set the new deadline
deadline = _deadline;
​
// emit the event
emit LogSetDeadline(_deadline);
}

However, deadline is not checked when executing a swap through executeSwapExactInputSingle() or executeSwapExactInput().

Impact

deadline is not checked.

Tools Used

Manual Review

Recommendations

Should check deadline when exeucting a swap in CurveAdapter.

Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

CurveAdapter does not enforce swap execution time limits like other adapters do

Appeal created

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.