Part 2

Summary

The function checkFeeDistributionNeeded is responsible for determining whether the collected fee should be distributed based on a minimum fee distribution threshold (minFeeDistributionValueUsd). The function compares the asset value in USD to this minimum threshold using the > operator:

Vulnerability Details

This strictly requires the asset value to be greater than the minimum threshold, meaning that if the asset value is exactly equal to the minFeeDistributionValueUsd, the function returns false, preventing the distribution.

The function excludes exact threshold values, causing unnecessary delays in fee distribution.

The function uses > instead of >=, requiring fees to be strictly greater than the minimum threshold.

If the collected fee equals the minimum threshold, distribution will not happen, even though it should.

This can result in fees accumulating in the contract longer than intended, delaying or even blocking distributions indefinitely if fees never exceed the threshold.

Impact

Fees will remain stuck in the contract if they do not exceed the threshold but match it.

Delays in distributing funds to recipients could impact operational efficiency.

If many fees hit the exact threshold but are not processed, it creates inefficiencies and forces keepers to call the function more frequently.

Tools Used

Manual Review

Recommendations

Modify the comparison operator from > to >= to ensure exact threshold values trigger distribution.