Part 2
Zaros
PerpetualsDEXFoundrySolidity
70,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Use implemented function instead of hardcoded formula

pontifex

Summary

The UniswapV3Adapter.executeSwapExactInput uses a hardcoded formula for the amountOutMinimum parameter calculation instead of using the calculateAmountOutMin function. This can cause problems if the calculateAmountOutMin function logic will be changed during update.

Vulnerability Details

function executeSwapExactInput(SwapExactInputPayload calldata swapPayload) external returns (uint256 amountOut) {
<...>
// Calculate the minimum acceptable output based on the slippage tolerance
uint256 amountOutMinimum =
(expectedAmountOut * (Constants.BPS_DENOMINATOR - slippageToleranceBps)) / Constants.BPS_DENOMINATOR;

Impact

Unintended behavior

Tools used

Manual Review

Recommendations

Consider using the calculateAmountOutMin function instead of formula.

Updates

Lead Judging Commences

inallhonesty Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.