Vulnerability Details

The function ZlpVault::maxDeposit calculates the maximum depositable assets based on the vault's deposit cap and total assets, but it does not emit an event to notify any changes or significant state updates. This is a potential vulnerability because key actions within the contract should typically trigger events for transparency and tracking, particularly when state variables are being modified.

Impact

1. Lack of Transparency: Without emitting an event, there is no record on the blockchain of the internal state change.

2. Increased Debugging Difficulty

Recommendations

Emit Event for State Update: Introduce an event that is emitted whenever the maxDeposit function is called and the state of the vault is queried or updated. The event should include the vault ID, deposit cap, and available assets for deposit.