The MultiSigWallet
contract uses a mix of custom errors and require
statements, leading to inconsistent error handling.
Some functions use custom errors (e.g., NotAnOwner
, AlreadyApproved
), while others use require
statements with string messages (e.g., "Invalid transaction ID"
). This inconsistency can make the code harder to maintain and debug.
Reduced code readability and maintainability.
Inconsistent user experience when errors occur.
Difficult to handle errors in the frontend when there is no consistency.
Manual code review.
Standardize error handling by using custom errors throughout the contract:
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.