DatingDapp

Summary

In the tokenURI function, we should add a check to ensure if the token exists before accessing its metadata to avoid potential issues.

Vulnerability Details

To ensure that the profile existence check is properly implemented, we can add a check in the tokenURI function to verify that the token exists before accessing its metadata.

Impact

Potential issues can arise when querying metadata for non-existent tokens.

Tools Used

no tools

Recommendations

Please follow the below steps.

Step1 - Modify the tokenURI function to add check.

function tokenURI(uint256 tokenId) public view virtual override returns (string memory) { if (!_exists(tokenId)) { revert ERC721Metadata__URI_QueryFor_NonExistentToken(); } string memory profileName = _profiles[tokenId].name; uint256 profileAge = _profiles[tokenId].age; string memory imageURI = _profiles[tokenId].profileImage; return string( abi.encodePacked( _baseURI(), Base64.encode( bytes( abi.encodePacked( '{"name":"', profileName, '", ', '"description":"A soulbound dating profile NFT.", ', '"attributes": [{"trait_type": "Age", "value": ', Strings.toString(profileAge), "}], ", '"image":"', imageURI, '"}' ) ) ) ) ); }

Step2- Implement the following code to Test the tokenURI function for a non-existent token and expect it to revert with the appropriate error. And test the mintProfile function to ensure that a profile can be minted and that the tokenURI function returns a valid URI for the minted token.

`// SPDX-License-Identifier: MIT
pragma solidity ^0.8.19;

import "forge-std/Test.sol";
import "../src/SoulboundProfileNFT.sol";

contract SoulboundProfileNFTTest is Test {
SoulboundProfileNFT private nft;

}`