Submission Details
Severity:
Multisig wallet will revert after every function call due to the onlyOwners() modifier
Summary
The MultiSig.sol::onlyOwners() modifier checks the msg.sender, however, it checks whether the msg.sender is equal to owner1 AND equal to owner2 or not. This will cause the modifier to revert every time a function is called since an address cannot be equal to two different addresses at the same time.
Vulnerability Details
This would be a critical vulnerability since the MultiSig.sol contract would be rendered useless as not a single function call would execute successfully.
Impact
The wallet would not be able to execute any transactions at all, the wallet would be unable to use.
Tools Used
Manual Review
Recommendations
modifier onlyOwners() {
- if (msg.sender != owner1 && msg.sender != owner2) revert NotAnOwner();
+ if (msg.sender != owner1 || msg.sender != owner2) revert NotAnOwner();
_;
}
Rewards breakdown
nSLOC
197This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.