DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of Event Emission for MultiSig Wallet Creation in `LikeRegistry::matchRewards` function may lead to Monitoring Challenges

lamassu

Severity

Impact: Low
Likelihood: High
Severity: Low

Vulnerability Details

The LikeRegistry::matchRewards function does not emit an event after creating a MultiSig wallet.

Impact

Without an event, monitoring the contract post-deployment becomes more challenging. Emitting an event would allow the contract owner to track MultiSig wallet creation and ensure proper protocol operation.

Tools Used

Manual Review

Recommendations

  1. Define a New Event

event Matched(address indexed user1, address indexed user2);
+ event MultiSigWalletCreated(address indexed walletAddress, address indexed user1, address indexed user2)

  1. Modify the LikeRegistry::matchRewards to Emit the Event

MultiSigWallet multiSigWallet = new MultiSigWallet(from, to);
+ emit MultiSigWalletCreated(address(multiSigWallet), from, to);
Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.