DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Potential Reentrancy Vulnerability in `MultiSig::executeTransaction()` function

mishraji874

Description: The MultiSig::executeTransaction() method lacks reentrancy guards, making the contract susceptible to recursive call attacks during ETH transfer.

Impact: Potential draining of contract funds through recursive calls

Proof of Concept:

function maliciousContract() external {
// Recursive call to drain funds
wallet.executeTransaction(txId);
}

Recommended Mitigation:

  • Implement standard ReentrancyGuard

  • Use the checks-effects-interactions pattern

  • Add mutex or reentrancy guard modifier

  • Update state before external call

Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_reentrancy_with_no_impact

matchRewards: Contract is created just before and is the one called. No impact. executeTransaction: CEI is followed. Emitting an event in disorder is informational in that context. withdraw: CEI is followed.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.