DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

[I-1] Use of unnamed imports instead of named imports reduces code clarity (Import Style + Code Maintainability)

oks_oks

Description: The contracts use unnamed imports instead of named imports. Named imports make it explicit which contracts and dependencies are being imported and used in the code.

Found in:

  1. SoulboundProfileNFT.sol:

import "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import "@openzeppelin/contracts/access/Ownable.sol";
import "@openzeppelin/contracts/utils/Strings.sol";

  1. LikeRegistry.sol:

import "./SoulboundProfileNFT.sol";
import "@openzeppelin/contracts/access/Ownable.sol";
import "./MultiSig.sol";

Impact: Using unnamed imports can make it harder to:

  • Track which contracts are actually being used

  • Identify naming conflicts

  • Maintain the code as the project grows

Recommended Mitigation: Use named imports to explicitly specify which contracts are being imported:

import {ERC721} from "@openzeppelin/contracts/token/ERC721/ERC721.sol";
import {Ownable} from "@openzeppelin/contracts/access/Ownable.sol";
import {Strings} from "@openzeppelin/contracts/utils/Strings.sol";
import {SoulboundProfileNFT} from "./SoulboundProfileNFT.sol";
import {MultiSig} from "./MultiSig.sol";
Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.