DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

`public` functions not used internally could be marked `external`

Instead of marking a function as public, consider marking it as external if it is not used internally.

3 Found Instances
  • Found in src/SoulboundProfileNFT.sol Line: 69

    function transferFrom(address, address, uint256) public pure override {
  • Found in src/SoulboundProfileNFT.sol Line: 74

    function safeTransferFrom(address, address, uint256, bytes memory) public pure override {
  • Found in src/SoulboundProfileNFT.sol Line: 80

    function tokenURI(uint256 tokenId) public view virtual override returns (string memory) {
Updates

Appeal created

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.