DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Not ideal variable type costs more gas

epintos

Summary

Some variables can be declared as constant or immutable to save gas.

Vulnerability Details

  • profileNFT variable in LinkRegistry should be declared as immutable since it is only set in the constructor once.

  • FIXEDFEE variable in LinkRegistry should be declared as constant since it has a fix value and it's never changed. Also as a best practice it should be called FIXED_FEE.

Impact

The current variable types use more gas.

Tools Used

  • Manual Review

  • slither

Recommendations

Change variable types as mentioned in Vulnerability Details. The new types won't require reading storage values and that would reduce gas.

Updates

Appeal created

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.