DatingDapp

Summary

The tokenURI method encodes the NFT metadata in Base64. While Base64 encoding is common in some contexts, in this implementation it may be unnecessary and counterproductive. Encoding the JSON metadata in Base64 can complicate off-chain processing, potentially cause interoperability issues with platforms expecting plain JSON, and lead to increased gas consumption due to additional encoding overhead.

Vulnerability Details

• The current implementation of tokenURI encodes a JSON metadata object in Base64. This results in a URI that is not easily readable or parsable by off-chain applications expecting a standard JSON metadata URI.

• The additional encoding layer introduces extra computational steps, which may increase gas costs during the tokenURI call.

• There is also a potential risk for tooling incompatibility; some NFT platforms or metadata aggregators might expect a plain JSON response and may not correctly decode Base64, leading to issues in displaying NFT details.

Impact

• Off-chain systems may not be able to correctly interpret or display NFT metadata, potentially impacting NFT applications that rely on standard metadata formats.

• The extra Base64 encoding increases the complexity of the tokenURI and, in some cases, may incur additional gas expenses.

• If the Base64 encoded metadata is not supported or expected by external platforms, it may lead to broken user experiences, underrepresentation of the NFT’s attributes, or even rejection of the NFT on some platforms.

Recommendations

Remove the Base64 encoding layer from the tokenURI function. Instead of encoding the metadata into Base64, return a plain JSON metadata string or a direct URL pointing to off-chain metadata storage that serves the JSON directly. For example, modify the tokenURI function as follows: