DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of tracking for deployed `MultiSigWallet` can lead to potential loss of funds

0xshuayb

Summary

The LikeRegistry contract does have any means to keep track of MultiSigWallet deployed in the LikeRegistry::matchRewards function

Vulnerability Details

Users have no direct way to find their MultiSigWallet address after it's deployed. Without emitting an event with the new wallet's address or storing it somewhere, users won't know where their funds went

Impact

Severe disruption of the protocol's functionality as users won't be able to access funds sent to the MultiSigWallet

Tools Used

Manual review

Recommendations

Add a means to track deployed MultiSigWallets like a mapping and a event emission whenever a MultiSigWallet is created

+ mapping(address => mapping(address => address)) public matchToMultiSig;
+ event MultiSigWalletCreated(address indexed user1, address indexed user2, address walletAddress);
.
.
.
function matchRewards(address from, address to) internal {
uint256 matchUserOne = userBalances[from];
uint256 matchUserTwo = userBalances[to];
​
userBalances[from] = 0;
userBalances[to] = 0;
​
uint256 totalRewards = matchUserOne + matchUserTwo;
uint256 matchingFees = (totalRewards * FIXEDFEE) / 100;
uint256 rewards = totalRewards - matchingFees;
totalFees += matchingFees;
​
// Deploy a MultiSig contract for the matched users
MultiSigWallet multiSigWallet = new MultiSigWallet(from, to);
+ matchToMultiSig[from][to] = address(multiSigWallet);
+ matchToMultiSig[to][from] = address(multiSigWallet);
​
// Send ETH to the deployed multisig wallet
(bool success,) = payable(address(multiSigWallet)).call{value: rewards}("");
require(success, "Transfer failed");
}
Updates

Appeal created

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.