DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Event Matched doesn't log created multisig address

mnedelchev_

Summary

When likes are matched event Matched isn't logging the address of the created MultiSigWallet contract.

Impact

Hard for off-chain dApps & monitoring to get the address of the MultiSigWallet.

Recommendations

Update event Matched to include also 3rd parameter address type:

event Matched(address indexed user1, address indexed user2, address multiSigWallet);

Move the event emission after the creation of the MultiSigWallet inside method matchRewards:

MultiSigWallet multiSigWallet = new MultiSigWallet(from, to);
emit Matched(from, to, address(multiSigWallet));
Updates

Appeal created

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.