DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

`executeTransaction` function lack of reentrancy attack protect

Summary

executeTransaction function use call function to tranfer eth but lack of protection against reentrancy attacks.

Vulnerability Details

executeTransaction function just have onlyOwners but no have nonReentrant to protect reentrancy attacks.

function executeTransaction(uint256 _txId) external onlyOwners {

Impact

Function can be reentrancy attack

Tools Used

Manual

Recommendations

Add nonReentrant to function.

Updates

Appeal created

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_reentrancy_with_no_impact

matchRewards: Contract is created just before and is the one called. No impact. executeTransaction: CEI is followed. Emitting an event in disorder is informational in that context. withdraw: CEI is followed.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.