Submission Details
Severity:
The modifier `MultiSigWallet::onlyOwners` checks if `msg.sender` is both `owner1` and `owner2` which leads to failure of condition everytime
Description:
The modifier MultiSigWallet::onlyOwners is supposed to check msg.sender is either owner1 or owner2. Since it can't be owner1 and owner2 at the same time, this leads to failure of its intended functionality and users can't access functions which use this modifier.
Impact:
Users won't be able to submit , approve or execute transaction through their multisig wallet.
Recommended Mitigation:
Easy and effective change,
modifier onlyOwners() {
- if (msg.sender != owner1 && msg.sender != owner2) revert NotAnOwner();
+ if (msg.sender !=owner1 || msg.sender!=owner2) revert NotAnOwner();
_;
}
Rewards breakdown
nSLOC
197This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.